Skip to content

BinaryHeap::drain doesn't document its iteration order #23564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apasel422 opened this issue Mar 20, 2015 · 1 comment · Fixed by #23617
Closed

BinaryHeap::drain doesn't document its iteration order #23564

apasel422 opened this issue Mar 20, 2015 · 1 comment · Fixed by #23617

Comments

@apasel422
Copy link
Contributor

This type's other iterator-returning methods indicate that the iterator is arbitrarily ordered, but drain doesn't say either way:

Clears the binary heap, returning an iterator over the removed elements.
@Gankra
Copy link
Contributor

Gankra commented Mar 20, 2015

For reference to anyone who wants to fix this, It's the exact same order as all the others.

@Gankra Gankra added the A-docs label Mar 20, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this issue Mar 22, 2015
@steveklabnik
Note order of BinaryHeap::drain
3d04cb3 
Fixes rust-lang#23564
@steveklabnik steveklabnik mentioned this issue Mar 22, 2015
Merged
bors added a commit that referenced this issue Mar 25, 2015
@bors
Auto merge of #23617 - steveklabnik:gh23564, r=Manishearth
3569377 
Fixes #23564
Manishearth added a commit to Manishearth/rust that referenced this issue Mar 25, 2015
@Manishearth
Rollup merge of rust-lang#23617 - steveklabnik:gh23564, r=Manishearth
b6783e6 
Fixes rust-lang#23564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Note order of BinaryHeap::drain steveklabnik/rust
2 participants
@Gankra @apasel422