-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename extensions
to methods
in libs
#2371
Comments
Agreed |
Actually I'm wondering if both names aren't wrong. One problem I'm finding in practice is that if all impls have the same name, it's hard to sort out what you want to use and what you want to export. Here is the scenario I'm talking about:
I am wondering if it wouldn't be better to name the impl after the type in question. Then you could (easily) export just the methods for your type and not others, and you can use a type and its methods by doing:
All that said, I suppose that #1893 addresses this too:
That's another benefit of #1893 I hadn't considered. So I don't know, maybe |
Closing this since separately-named impls are going away. Reopen if you think I misunderstood. |
…71, r=blyxyas Add regression ui test for rust-lang#2371 Fixes rust-lang#2371. rust-lang#2371 seems to already be handled correctly in the lint. This PR adds a ui regression test so we can close it. r? `@blyxyas` changelog: Add regression ui test for rust-lang#2371
methods
is shorter, maybe more descriptiveThe text was updated successfully, but these errors were encountered: