Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coherence regression from RFC 1023 #24241

Closed
nikomatsakis opened this issue Apr 9, 2015 · 1 comment · Fixed by #24245
Closed

coherence regression from RFC 1023 #24241

nikomatsakis opened this issue Apr 9, 2015 · 1 comment · Fixed by #24245
Assignees
Labels
P-medium Medium priority
Milestone

Comments

@nikomatsakis
Copy link
Contributor

This example should not pass coherence, and it doesn't used to, but it does now:

trait From<U> {
    fn from(U)
    -> Self;
}

impl <T> From<T> for T {
    fn from(t: T) -> T { t }
}

impl <T11: From<U11>, U11> From<(U11,)> for (T11,) {
    #[allow(non_snake_case)]
    fn from(u: (U11,)) -> (T11,) { let (U11,) = u; (T11::from(U11),) }
}

fn main() { /* foo(From::from(("foo", 1u16))); */ }
@nikomatsakis
Copy link
Contributor Author

triage: P-high (1.0)

@rust-highfive rust-highfive added the P-medium Medium priority label Apr 9, 2015
@rust-highfive rust-highfive added this to the 1.0 milestone Apr 9, 2015
nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Apr 9, 2015
coherence. Skolemized parameters wind up preventing unification.
Surprised we had no test for this! Fixes rust-lang#24241.
@nikomatsakis nikomatsakis self-assigned this Apr 9, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

 Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 10, 2015
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 11, 2015
…failure, r=pnkfelix

 Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants