Skip to content

How to I-nominate a closed PR tagged with beta-nominated+beta-accepted? #24940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pnkfelix opened this issue Apr 29, 2015 · 2 comments
Closed

Comments

@pnkfelix
Copy link
Member

How to I-nominate a closed PR tagged with beta-nominated+beta-accepted?

For example #24724 ? The latter is closed, and so the usual search for I-nominated tagged issues will miss it, since we usually only look at open issues tagged as such.

(I suspect that it might actually suffice to just open an issue each time this event occurs, since I suspect it should be a relatively rare occurrence.)

@pnkfelix
Copy link
Member Author

triage: I-nominated

This is both a process issue at the meta-level, but it also serves as a proxy for the (closed, beta-nominated, beta-accepted) PR #24724.

@pnkfelix pnkfelix changed the title How to I-nominate a closed PR tagged with beta-nominated+accepted? How to I-nominate a closed PR tagged with beta-nominated+beta-accepted? Apr 29, 2015
@pnkfelix
Copy link
Member Author

good idea from @alexcrichton : just remove beta-accepted when a (nominated,accepted) PR is contentious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants