std: Add missing stability for symlink functions #24724
Conversation
These functions were intended to be introduced as `#[stable]` as a stable API was deprecated in favor of them, but they just erroneously forgot the stability attributes.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Nominating for beta inclusion as well |
alexcrichton
added
the
beta-nominated
|
going from nominated to (nominated, accepted) |
pnkfelix
added
the
beta-accepted
|
@bors: p=10 |
These functions were intended to be introduced as `#[stable]` as a stable API was deprecated in favor of them, but they just erroneously forgot the stability attributes.
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry On Fri, Apr 24, 2015 at 5:40 PM, bors notifications@github.com wrote:
|
|
⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-64-nopt-t are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-opt... |
|
💔 Test failed - auto-linux-32-opt |
|
@bors: retry On Fri, Apr 24, 2015 at 7:45 PM, bors notifications@github.com wrote:
|
These functions were intended to be introduced as `#[stable]` as a stable API was deprecated in favor of them, but they just erroneously forgot the stability attributes.
|
triage: I-nominated Nominating for discussion at triage meeting. This PR has been put into the state (beta-accepted, beta-nominated), but it seems the prerequisite PR #24222 was never accepted (or even nominated) for inclusion in beta. (If the original beta-nomination of this PR #24724 was meant to be interpreted as implicit beta-nomination of PR #24222, that was not how I remember the presentation of the situation at the meeting. There is a big difference between adding some accidentally omitted stability tags versus actually back-porting a change to the libraries.) |
|
hmm, I am a little worried that this nomination tag will not actually show up in our usual queries ... I will open an issue just to make sure this is caught ... |
|
decision: remove all the tags. |
pnkfelix
removed
beta-accepted
These functions were intended to be introduced as
#[stable]as a stable APIwas deprecated in favor of them, but they just erroneously forgot the stability
attributes.