Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize calling tcp.shutdown multiple times across OSes #25164

Closed
seanmonstar opened this issue May 7, 2015 · 3 comments
Closed

Normalize calling tcp.shutdown multiple times across OSes #25164

seanmonstar opened this issue May 7, 2015 · 3 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools

Comments

@seanmonstar
Copy link
Contributor

Calling tcp.shutdown(how) multiple times will return different values, depending on the OS. On Linux, it returns Ok(()), on OS X, it returns ErrorKind::NotConnected.

Perhaps this behavior could be made to be the same across platforms. If not, at the least, the docs should call it out.

Noticed from hyperium/hyper#508

/cc @aturon @alexcrichton
@steveklabnik steveklabnik added A-libs and removed A-docs labels May 7, 2015
@steveklabnik
Copy link
Member

Tagging as libs until the decision is made that this is different across platforms.

@nagisa
Copy link
Member

nagisa commented May 9, 2015

I don’t think we can do anything sensible here.

@steveklabnik
Copy link
Member

Triage: re-tagging as docs to make mention of this

@steveklabnik steveklabnik added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Mar 10, 2017
@steveklabnik steveklabnik mentioned this issue Apr 24, 2017
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 26, 2017
@steveklabnik
Address platform-specific behavior in TcpStream::shutdown
29e6656 
Fixes rust-lang#25164
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41499 - steveklabnik:gh25164, r=alexcrichton
db07dd1 
Address platform-specific behavior in TcpStream::shutdown

Fixes rust-lang#25164

r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41499 - steveklabnik:gh25164, r=alexcrichton
88bdbc7 
Address platform-specific behavior in TcpStream::shutdown

Fixes rust-lang#25164

r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
arielb1 pushed a commit to arielb1/rust that referenced this issue Apr 26, 2017
Rollup merge of rust-lang#41499 - steveklabnik:gh25164, r=alexcrichton
a6e6df8 
Address platform-specific behavior in TcpStream::shutdown

Fixes rust-lang#25164

r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
arielb1 pushed a commit to arielb1/rust that referenced this issue Apr 26, 2017
Rollup merge of rust-lang#41499 - steveklabnik:gh25164, r=alexcrichton
84f6e01 
Address platform-specific behavior in TcpStream::shutdown

Fixes rust-lang#25164

r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @seanmonstar @alexcrichton @nagisa