-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rustdoc search for "slice" should have primitive as top result #25167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@alexcrichton do you know if the search indexing could have 'prioritizing' like this? |
@cmr From a quick glance at rustdoc's So, making types more important, moving 'primitive' up in the types array (or adding a special case for primitives) are good options. |
@killercup Sounds like you should make a PR! |
Maybe over the weekend! On Thu, May 7, 2015 at 8:42 PM, Corey Richardson notifications@github.com
|
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
When browsing documentation and searching for "slice", the top three results are:
std::slice
the modulestd::raw::Slice
the struct representationstd::slice
the primitiveI think
std::slice
-the-primitive should be the top result (it is currently the third result), because it tells me what I can do to a slice, which is usually what I'm wondering about when I search for "slice".std::slice
-the-module gives meager documentation, and links to structs, which I'm comparatively rarely interested in./cc @steveklabnik since you're the documentation guy?
The text was updated successfully, but these errors were encountered: