Skip to content

ScopedKey<T> has unnecessary implicit Sized bound #25193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Diggsey opened this issue May 7, 2015 · 1 comment
Closed

ScopedKey<T> has unnecessary implicit Sized bound #25193

Diggsey opened this issue May 7, 2015 · 1 comment

Comments

@Diggsey
Copy link
Contributor

Diggsey commented May 7, 2015

ScopedKey only ever deals with references or pointers to T, so the Sized bound is unnecessary. This is required for storing trait objects and other DSTs in a scoped_thread_local!

I'll submit a PR fixing this imminently.
@Diggsey Diggsey mentioned this issue May 9, 2015
Closed
Diggsey added a commit to Diggsey/rust that referenced this issue May 9, 2015
@Diggsey
Remove Sized bound from scoped_thread_local! and ScopedKey
ef1dfaf 
Fixes rust-lang#25193

Fix whitespace
@alexcrichton
Copy link
Member

The associated PR ended up being closed because the OS actually only allows us to store one pointer, so I think that we're going to stick with this for now. We can possibly expand it in the future if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Sized bound from scoped_thread_local! and ScopedKey Diggsey/rust
3 participants
@steveklabnik @alexcrichton @Diggsey