Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor glue regressed rustc performance by 8 seconds #2558

Closed
pcwalton opened this issue Jun 9, 2012 · 3 comments · May be fixed by devcode1981/rust#6 or MarcelRaschke/rust#6
Closed

Visitor glue regressed rustc performance by 8 seconds #2558

pcwalton opened this issue Jun 9, 2012 · 3 comments · May be fixed by devcode1981/rust#6 or MarcelRaschke/rust#6
Labels
A-codegen Area: Code generation I-slow Issue: Problems and improvements with respect to performance of generated code.
Milestone
0.4

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Jun 9, 2012

Are we not generating it lazily?
@pcwalton
Copy link
Contributor Author

pcwalton commented Jun 9, 2012

cc @graydon

@ghost ghost assigned graydon Jun 14, 2012
@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

Lazily, yes, but it's generated for anything that has a full tydesc instantiated, which is a lot of them. Anything boxed, say.

@graydon
Copy link
Contributor

graydon commented Aug 29, 2012

I don't think there's a bug here to be fixed, since we're going to continue generating this code. If it turns out to be hot in profiles we'll spend time optimizing it like anything else, but otherwise the feature's not backing out, so.. closing. LMK if you think this is wrong.

@graydon graydon closed this as completed Aug 29, 2012
oli-obk pushed a commit to oli-obk/rust that referenced this issue Sep 23, 2022
@bors
Auto merge of rust-lang#2558 - RalfJung:tag-gc, r=saethlin
439f58b 
readme: tag-gc tweaks

r? `@saethlin`

Is this option truly needed often enough that it should be in the 'common' section? If not I vote for moving it to the 2nd section. Also `10,000` is a confusing way to write numbers in an international context (in many languages, `,` in a number plays the role of the point in English number notation, so using a space or underscore is less likely to lead to confusion).
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 4, 2022
@bors
Auto merge of rust-lang#2558 - RalfJung:tag-gc, r=saethlin
6671f83 
readme: tag-gc tweaks

r? `@saethlin`

Is this option truly needed often enough that it should be in the 'common' section? If not I vote for moving it to the 2nd section. Also `10,000` is a confusing way to write numbers in an international context (in many languages, `,` in a number plays the role of the point in English number notation, so using a space or underscore is less likely to lead to confusion).
This was referenced Oct 22, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
0.4
2 participants
@graydon @pcwalton