Skip to content

Builds with multiple --host's are broken #25723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue May 22, 2015 · 4 comments · Fixed by #25799
Closed

Builds with multiple --host's are broken #25723

brson opened this issue May 22, 2015 · 4 comments · Fixed by #25799

Comments

@brson
Copy link
Contributor

brson commented May 22, 2015

The build system now expects all non-build-triple platforms to use an explicit linker, but no platforms provide this but MSVC.

cc #25719

@brson
Copy link
Contributor Author

brson commented May 22, 2015

The problem is the LINK_{triple} variables in platform.mk are all undefined.

@brson
Copy link
Contributor Author

brson commented May 22, 2015

cc @alexcrichton

@Stebalien
Copy link
Contributor

cc #25727

alexcrichton added a commit to alexcrichton/rust that referenced this issue May 26, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes rust-lang#25723
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 26, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes rust-lang#25723
@alexcrichton
Copy link
Member

guh, sorry about this!

alexcrichton added a commit to alexcrichton/rust that referenced this issue May 26, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes rust-lang#25723
bors added a commit that referenced this issue May 27, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes #25723
bors added a commit that referenced this issue May 27, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes #25723
Closes #25802
XMPPwocky pushed a commit to XMPPwocky/rust that referenced this issue May 29, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes rust-lang#25723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants