Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build date from --version #25812

Closed
brson opened this issue May 27, 2015 · 4 comments · Fixed by #25821
Closed

Remove build date from --version #25812

brson opened this issue May 27, 2015 · 4 comments · Fixed by #25821

Comments

@brson
Copy link
Contributor

brson commented May 27, 2015

I added this some months ago because I thought it would help stem confusion about the reported commit date when it happens to be a few days behind the release artifacts. I no longer think this is a great idea for two reasons:

  1. This date is not guaranteed to be the same across platforms. There have been occasions when the builds were spread across multiple days. Because these strings are not guaranteed to be the same one can't compare the output of two rustc --version invocations to check for equivalence, which is something I have wanted to do (I think one of my tools has to frob this string to eliminate the build date). Fixing this would require more complexity in the buildbot config than I'm comfortable with atm.

  2. The commit date for nightlies should never actually be more than 1-2 days behind the distribution date since the head commit is always a merge commit. The original motivation for adding the build date may not have been very strong.

@brson brson added the A-build label May 27, 2015
@brson
Copy link
Contributor Author

brson commented May 27, 2015

In some sense this is a stable breaking change since tools do parse the output of --version. I think we can get away with it though. cc @alexcrichton

@alexcrichton
Copy link
Member

Yeah I agree with the rationale here, and I also agree that I think we can get away with it.

@nrc
Copy link
Member

nrc commented Jun 4, 2015

We should be advertising these changes more widely - anything that could break anything should be at least posed on internals and give some notice that things will change. I agree with the change here, but it would be nice to update my scripts in advance rather than after a few days of them being broken.

@DanielKeep
Copy link
Contributor

Well great, now I have to get the build date some other way for my rustup.ps1 script.

I actually did notice that the reported build date and the Last-Modified timestamp on the downloads were out a bit, so I was fuzzing them. I suppose I can just grab the timestamp from the compiler executable itself.

Ah well. :)

alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants