Skip to content

Pass mapper's first argument by move, in test/bench/task-perf-word-count-generic #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 14, 2012 · 1 comment
Closed

Pass mapper's first argument by move, in test/bench/task-perf-word-count-generic #2599

catamorphism opened this issue Jun 14, 2012 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

A FIXME before the mapper type said that the first K1 argument should be passed by move, but that it didn't parse. Changing K1 to -K1 on the right-hand side does parse now, but I couldn't figure out how to write the loop in start_mapper in such a way as to move out the elements of inputs.
@ghost ghost assigned eholk Jun 14, 2012
@eholk
Copy link
Contributor

eholk commented Jun 22, 2012

On second thought, I don't think this really needs to be by move. I'll remove the FIXME and then close the bug.

eholk added a commit that referenced this issue Jun 22, 2012
@eholk
Use must_have_lock instead of private functions. (Issue #2700)
26c11f7 
I hereby declare that messages sent from the same source arrive in order (Issue #2605)

Removing FIXME, owned is the correct type here. (Issue #2704)

Remove outdated FIXME (Issue #2703)

Updating test for spawning native functions (Issue #2602)

Removing bogus FIXME (Issue #2599)
@eholk eholk closed this as completed Jun 22, 2012
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws
Update dependencies (rust-lang#2599)
634924b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@eholk @catamorphism