Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse URLs fully (in cargo) #2661

Closed
graydon opened this issue Jun 21, 2012 · 3 comments
Closed

Parse URLs fully (in cargo) #2661

graydon opened this issue Jun 21, 2012 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
old 1.0 milestone

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

We should just have a URL library in std. It's a normal function these days.
@brson
Copy link
Contributor

brson commented Aug 1, 2012

What does fully parsing urls in cargo entail? Where are we not doing so?

@brson brson closed this as completed Aug 1, 2012
@brson brson reopened this Aug 1, 2012
@graydon
Copy link
Contributor Author

graydon commented Aug 9, 2012

std::net_url is fine as far as the stdlib part goes; it's just that in cargo.rs we have some kinda ad-hoc string scanning (has_archive_extension, is_archive_url, is_git_url, assume_source_method) that should probably delegate to std::net_url.

@z0w0
Copy link
Contributor

z0w0 commented Mar 8, 2013

Closing because Cargo is obsolete as of version 0.6. Rustpkg makes use of both std::net_url for bare URLs and paths for custom sources (not sure what they're called yet).

@z0w0 z0w0 closed this as completed Mar 8, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 29, 2023
@bors
Auto merge of rust-lang#2661 - DrMeepster:deref_operand_as, r=oli-obk
b4b7cd6 
Dereference pointers in shims as correct types

Currently, shims will dereference pointers as the type written by the user. This can cause false positives, incorrect behavior such as rust-lang#2136, and even ICEs if a field is not present.

This PR fixes this by having shims dereference pointers with types from `std` or `libc` that we can rely on the layout and field names of instead of with whatever the user passed in.

Fixes rust-lang#1123
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@remi-delmas-3000 @adpaco-aws
Update toolchain to nightly 2023-08-04 (rust-lang#2661)
63f513f 
Co-authored-by: Remi Delmas <delmasrd@amazon.com>
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
3 participants
@graydon @brson @z0w0