Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Pressing back after search doesn't reset <title> #26673

Closed
frewsxcv opened this issue Jun 30, 2015 · 8 comments
Closed

rustdoc: Pressing back after search doesn't reset <title> #26673

frewsxcv opened this issue Jun 30, 2015 · 8 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@frewsxcv
Copy link
Member

  1. Navigate to https://doc.rust-lang.org/nightly/std/index.html
  2. Type a query in the search bar (wait for results to appear)
  3. Take note of the title of the search results
  4. Press 'back' and notice how the title doesn't reset
@jooert
Copy link
Contributor

jooert commented Jun 30, 2015

Which browser are you using? It does work fine for me in Firefox 38 on Linux.

@frewsxcv
Copy link
Member Author

Latest stable Firefox and latest stable Chrome on OSX 10.10

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 30, 2015
@yberreby
Copy link

Doesn't reset for me on OS X 10.10.2 (Yosemite), Chrome 43.0.2357.130.

@feroldi
Copy link

feroldi commented Jun 30, 2015

Doesn't reset here. Mozilla Firefox 38.0.5 on Manjaro Linux 0.8.13.

@jooert
Copy link
Contributor

jooert commented Jun 30, 2015

My browser probably cached an old version, now it doesn't reset on my setup, too.

@nhowell nhowell mentioned this issue Jul 2, 2015
Merged
@frewsxcv
Copy link
Member Author

This still happens for me, but that might be because #26732 hasn't been deployed yet

@Gankra
Copy link
Contributor

Gankra commented Jul 19, 2015

Should have been deployed to nightly, but it clearly hasn't:

https://doc.rust-lang.org/nightly/std/

Edit: hmm, actually it only landed a couple days ago... maybe hasn't made it.

@Gankra Gankra reopened this Jul 19, 2015
@Gankra
Copy link
Contributor

Gankra commented Jul 19, 2015

This change just barely missed landing in the last nightly.

@Gankra Gankra closed this as completed Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@steveklabnik @frewsxcv @Gankra @jooert @yberreby @feroldi