Skip to content

See if we can avoid calloc in shared_malloc #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graydon opened this issue Jun 21, 2012 · 1 comment
Closed

See if we can avoid calloc in shared_malloc #2682

graydon opened this issue Jun 21, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.
Milestone
old 1.0 milestone

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

It's an extra cost and might not be required.
@pcwalton
Copy link
Contributor

pcwalton commented Jan 6, 2013

This does not appear to be necessary. Pushed a fix. The fix had no impact at all on performance.

@pcwalton pcwalton closed this as completed Jan 6, 2013
pcwalton added a commit to pcwalton/rust that referenced this issue Jan 6, 2013
@pcwalton
rt: Stop zeroing out all allocations. Unobservable perf win. Closes r…
6c18c75 
…ust-lang#2682. rs=negligible-perf-win
@brson brson mentioned this issue Feb 2, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@graydon @pcwalton