Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negate_unsigned feature gate warning should be changed to feature gate. #27141

Closed
nagisa opened this issue Jul 20, 2015 · 5 comments
Closed

negate_unsigned feature gate warning should be changed to feature gate. #27141

nagisa opened this issue Jul 20, 2015 · 5 comments

Comments

@nagisa
Copy link
Member

nagisa commented Jul 20, 2015

negate_unsigned feature gate (librustc_lint/builtin.rs) currently emits a warning instead of actual feature_gate due to backwards compatibility concerns. After some time passes this warning should be converted to feature gate.

Basically, reverting the “Convert negate_unsigned feature gate to a warning” commit (0ca8e49) from #27026 and fixing up conflicts (if any) should do.

Note to any people who are planning to do this: ask somebody from language team whether enough time has passed since we started to emit the warning before submitting a PR.

@steveklabnik
Copy link
Member

/cc @rust-lang/lang

@pnkfelix
Copy link
Member

pnkfelix commented Aug 7, 2015

I think once the next beta has been released (that is, when the current nightly has been shifted over to beta as part of the release train) we can go ahead and apply this change to nightly.

@steveklabnik
Copy link
Member

Did this end up happening?

@steveklabnik
Copy link
Member

/cc @rust-lang/libs

@nagisa
Copy link
Member Author

nagisa commented Sep 3, 2015

This has not been done yet.

I’ve asked @pnkfelix several times on IRC which shift he had in mind (1.3 to beta or 1.4 to beta), because his comment was posted on the day of such shift, but never got a response.

EDIT: well, it won’t hurt more doing this later (after 1.4 shifts to beta) than sooner (now).

nagisa added a commit to nagisa/rust that referenced this issue Sep 18, 2015
This reverts commit 0ca8e49 and fixes the code to work with
current rustc.

Fixes rust-lang#27141
bors added a commit that referenced this issue Sep 18, 2015
bors added a commit that referenced this issue Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants