Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rust_task::running and friends #2787

Closed
eholk opened this issue Jul 3, 2012 · 2 comments
Closed

Remove rust_task::running and friends #2787

eholk opened this issue Jul 3, 2012 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Milestone
old 1.0 milestone

Comments

@eholk
Copy link
Contributor

eholk commented Jul 3, 2012

These are inherently racy. Their presence encourages people to write racy code. We should remove them to make things safer.
@bblum
Copy link
Contributor

bblum commented Jul 6, 2012

seems like you should do this, given your existing closeness to the state transition code?

@ghost ghost assigned eholk and bblum Jul 6, 2012
@bblum
Copy link
Contributor

bblum commented Jul 11, 2012

i will do it

bblum added a commit that referenced this issue Jul 11, 2012
@bblum
Unify state_lock + kill_lock -> lifecycle_lock (#2787)
74f4b8d
@bblum bblum mentioned this issue Jul 11, 2012
Closed
@bblum bblum closed this as completed in 343e9de Jul 12, 2012
@eholk eholk unassigned bblum Jun 16, 2014
saethlin pushed a commit to saethlin/rust that referenced this issue Apr 11, 2023
@bors
Auto merge of rust-lang#2787 - DebugSteven:move-fcntl, r=oli-obk
7373197 
move reject with isolation logic in fcntl

This PR moves the block of logic inside `fcntl` to reject if isolation is enabled into the branch checking if the command is `F_FULLFSYNC` on apple. This allows `fcntl` to duplicate file descriptors while using isolation.

This means we can now run the tokio tests with isolation.

This PR allows moves the now passing `fcntl` logic from `libc-fs-with-isolation.rs` into two different tests:
- `fcntl(1, libc::F_DUPFD, 0)` succeeds with isolation
- `fcntl(1, libc::F_FULLFSYNC, 0)` fails with isolation on MacOS
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@JustusAdam @feliperodri
Fix issue 2589 (rust-lang#2787)
e95a7bb 
Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@eholk @bblum