Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntoIterator not implemented for &Option and &Result #27996

Closed
birkenfeld opened this issue Aug 25, 2015 · 1 comment
Closed

IntoIterator not implemented for &Option and &Result #27996

birkenfeld opened this issue Aug 25, 2015 · 1 comment

Comments

@birkenfeld
Copy link
Contributor

To be consistent with Vec and other collections, shouldn't these types also get the IntoIterator impls for &T and &mut T?
@alexcrichton
Copy link
Member

Yeah this should be fine to implement, it's just an oversight.

@birkenfeld birkenfeld mentioned this issue Aug 27, 2015
Merged
birkenfeld added a commit to birkenfeld/rust that referenced this issue Aug 27, 2015
@birkenfeld
core: Implement IntoIterator for Option and Result references

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a7313a0 
Fixes rust-lang#27996.
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 27, 2015
@Manishearth
Rollup merge of rust-lang#28039 - birkenfeld:option_result_ref_intoit…
51cc430 
…er, r=alexcrichton

Fixes rust-lang#27996.

Does this need any `#[stable]`/`#[unstable]` attributes?
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 27, 2015
@Manishearth
Rollup merge of rust-lang#28039 - birkenfeld:option_result_ref_intoit…
07d1a22 
…er, r=alexcrichton

Fixes rust-lang#27996.

Does this need any `#[stable]`/`#[unstable]` attributes?
@KeyboardDanni KeyboardDanni mentioned this issue Jan 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @birkenfeld