Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken anchor links in new Error Handling guide #28412

Closed
yberreby opened this issue Sep 15, 2015 · 7 comments
Closed

Broken anchor links in new Error Handling guide #28412

yberreby opened this issue Sep 15, 2015 · 7 comments

Comments

@yberreby
Copy link

In the Error Handling guide, clicking the anchor link "A brief interlude: unwrapping isn't evil" in the table of contents has no effect.

It points to: https://doc.rust-lang.org/nightly/book/error-handling.html#a-brief-interlude-unwrapping-isnt-evil

...whereas the heading's anchor is: https://doc.rust-lang.org/nightly/book/error-handling.html#a-brief-interlude:-unwrapping-isn't-evil

EDIT: it's actually worse than that - it seems all headings containing special characters (<, >, !) have broken links:

@yberreby yberreby changed the title Broken anchor link in new Error Handling guide Broken anchor links in new Error Handling guide Sep 15, 2015
@swatteau
Copy link

The problem is apparently not limited to just headings. For example, the first sentence in the section https://doc.rust-lang.org/nightly/book/error-handling.html#the-option-type says : "The Option type is defined in the standard library" but the link provided leads to the section on pattern matching.

@alexispurslane
Copy link
Contributor

I'm sorry, I'll get right on that. Thanks for noticing, @filsmick.

@alexispurslane
Copy link
Contributor

@filsmick Thats strange, because in my local markdown viewer, all those links work.

@semmaz
Copy link
Contributor

semmaz commented Sep 15, 2015

@ChristopherDumas Yeah, the reason is because rustdoc doesn't discard special chars in sections id and href attributes.

@alexispurslane
Copy link
Contributor

Well, I fixed it now.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Sep 15, 2015
bors added a commit that referenced this issue Sep 16, 2015
@yberreby
Copy link
Author

https://doc.rust-lang.org/stable/book/error-handling.html#table-of-contents

Try clicking on "Composing Option values". Looks like the fix didn't make it to stable, because it works on the nightly version

@steveklabnik
Copy link
Member

@filsmick yes, it was fixed after 1.4 was branched. 1.5 has the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants