-
Notifications
You must be signed in to change notification settings - Fork 13.3k
RFC: Replace ports with pipes #2851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pipes are not an exact match, but with things like The way pipes interact with native code will be tricky. |
@eholk could you clarify what you mean by the last comment ("the way pipes interact with native code will be tricky")? Otherwise I agree, it sounds like pipes are overall superior in most ways to the older ports and channels, I'm happy to switch to them. |
@graydon Ports have a representation in the runtime, which means native code could call The tricky part that pipes would actually need to handle now is in With pipes, this is problematic for a couple reasons. First off, we can't just cast a pipe to a pointer, because they are not word sized anymore. Pipes can't directly be shared, although we could use |
Done. |
Output the tagged version in the `versioning` step of the release workflow to avoid a failure in the posterior docker build step (see rust-lang#2851 for more details). This has been tested in my fork, where: 1. Pushing the `kani-0.40.0` without any changes generated the same failure [in this run](https://github.com/adpaco-aws/rmc/actions/runs/6738081085/job/18317679294) 2. Committing the change in this PR and pushing the `kani-0.40.0` again resulted in a successful build [in this run](https://github.com/adpaco-aws/rmc/actions/runs/6738159804/job/18317924214) 3. The tagged image can be downloaded from my fork, as seen [here](https://github.com/adpaco-aws/rmc/pkgs/container/kani-ubuntu-20.04). Resolves rust-lang#2851
This is mostly just a tracking issue to hang other bugs off of. Assuming we can write all the programs we need to with pipes instead of ports and chans, we should replace the port/chan system with pipes.
The text was updated successfully, but these errors were encountered: