Creating data-less enum variant with data yields a confusing error message #28533

nagisa · 2015-09-20T10:59:45Z

enum Test {
    Variant,
    Variant2(&'static str)
}

fn main(){
    let y = Test::Variant2("Hello");
    let x = Test::Variant("World");
}

results in

<anon>:8:13: 8:35 error: expected function, found `Test`
<anon>:8     let x = Test::Variant("World");
                     ^~~~~~~~~~~~~~~~~~~~~~

The error should say something about variant not being able to contain any data instead.

The text was updated successfully, but these errors were encountered:

Reword error when data-less enum variant called as function Given a file like: ``` rust enum Test { Variant, Variant2 {a: u32}, } fn main(){ let x = Test::Variant("Hello"); let y = Test::Variant2("World"); } ``` Both errors now look similar: ``` bash error[E0423]: `Test::Variant2` is the name of a struct or struct variant, but this expression uses it like a function name --> file3.rs:10:13 | 10 | let y = Test::Variant2("Hello"); | ^^^^^^^^^^^^^^ struct called like a function | = help: did you mean to write: `Test::Variant2 { /* fields */ }`? error: `Test::Variant` is the name of a data-less enum, but this expression uses it like a function name --> file3.rs:9:13 | 9 | let x = Test::Variant("World"); | ^^^^^^^^^^^^^^^^^^^^^^ data-less enum called like a function | = help: did you mean to write: `Test::Variant`? note: defined here --> file3.rs:2:5 | 2 | Variant, | ^^^^^^^ error: aborting due to previous error ``` Re: #28533

Mark-Simulacrum · 2017-06-01T17:29:18Z

Closing, we suggest to not call it today and provide the definition site.

error: `Test::Variant` is being called, but it is not a function
 --> test.rs:8:13
  |
8 |     let x = Test::Variant("World");
  |             ^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: did you mean to write `Test::Variant`?
note: defined here
 --> test.rs:2:5
  |
2 |     Variant,
  |     ^^^^^^^

error: aborting due to previous error(s)

steveklabnik added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 28, 2015

estebank mentioned this issue Sep 16, 2016

Reword error when data-less enum variant called as function #36520

Merged

steveklabnik removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2017

Mark-Simulacrum closed this as completed Jun 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creating data-less enum variant with data yields a confusing error message #28533

Creating data-less enum variant with data yields a confusing error message #28533

nagisa commented Sep 20, 2015

Mark-Simulacrum commented Jun 1, 2017

Creating data-less enum variant with data yields a confusing error message #28533

Creating data-less enum variant with data yields a confusing error message #28533

Comments

nagisa commented Sep 20, 2015

Mark-Simulacrum commented Jun 1, 2017