Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check-stage1 is currently not working #28710

Closed
alexcrichton opened this issue Sep 28, 2015 · 3 comments
Closed

make check-stage1 is currently not working #28710

alexcrichton opened this issue Sep 28, 2015 · 3 comments

Comments

@alexcrichton
Copy link
Member

Lots of discussion as well as proposed fixes.

Looks like the best solution for now (from the discuss thread) is to just enable landing pads in all stages instead of just disabling in stage0.
This was referenced Sep 28, 2015
Closed
Closed
@nagisa
Copy link
Member

nagisa commented Sep 28, 2015

How about ./configure --disable-landing-pads for buildbot use and ./configure --enable-landing-pads by default for everybody else?

IMHO simple ./configure should by default do something that’s fit for developers to use; currently I have to already use quite a few flags, because ./configure is buildbot/release oriented.

@arielb1
Copy link
Contributor

arielb1 commented Sep 28, 2015

How about just fixing panics without landing pads?

@nagisa nagisa mentioned this issue Sep 28, 2015
Merged
bors added a commit that referenced this issue Oct 5, 2015
@bors
Auto merge of #28717 - nagisa:optional-no-landing-pads, r=<try>
c682cff 
Part of #28710

Landing pads during stage0 are now enabled by defaullt. Since this has its downsides and upsides either way, I made it possible to change the option through configure.
bors added a commit that referenced this issue Oct 5, 2015
@bors
Auto merge of #28717 - nagisa:optional-no-landing-pads, r=alexcrichton
6843ea4 
Part of #28710

Landing pads during stage0 are now enabled by defaullt. Since this has its downsides and upsides either way, I made it possible to change the option through configure.
@alexcrichton
Copy link
Member Author

This is quite old, and probably no longer true, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @nagisa @arielb1