Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vec::view when possible #2880

Closed
eholk opened this issue Jul 12, 2012 · 0 comments
Closed

Use vec::view when possible #2880

eholk opened this issue Jul 12, 2012 · 0 comments
Labels
A-lifetimes Area: Lifetimes / regions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
0.5

Comments

@eholk
Copy link
Contributor

eholk commented Jul 12, 2012

vec::slice allocates a new vector, when in most cases vec::view would be better since it doesn't have to allocate anything. Currently region inference makes this tricky.
@ghost ghost assigned eholk Jul 26, 2012
eholk added a commit that referenced this issue Jul 27, 2012
@eholk
Use iteration protocol for ebml, use vec::view in more places (issue #…
65beca4 
…2880)
@eholk eholk closed this as completed in 6d142c5 Jul 27, 2012
@eholk eholk removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue May 11, 2023
@bors
Auto merge of rust-lang#2880 - RalfJung:sync, r=RalfJung
a477b81 
increase timing slack for sync tests; port tests to 2021 edition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lifetimes Area: Lifetimes / regions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@eholk