Skip to content

[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors' #29063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcarral opened this issue Oct 15, 2015 · 2 comments
Closed

[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors' #29063

dcarral opened this issue Oct 15, 2015 · 2 comments

Comments

@dcarral
Copy link
Contributor

dcarral commented Oct 15, 2015

Context

After having first read about iterators the TRPL book, it called my attention the scarce number of matching results in the API docs for a query like "iterator adapters". Curiously enough, it looks like the term used there is "adaptors" instead of adapters.

Data

  • Appearances @ TRPL(*):
    • "iterator adapters" -> 7
    • "iterator adaptors" -> 1 (part of compilation output)
  • Appearances @ API docs(**):
    • "iterator adapters" -> 1 (book)
    • "iterator adaptors" -> 158

* Appearances found using typical 'Search in directory' feature in a text editor.
** Appearances found using the site search filter in Google, ie. "iterator adaptors" site:doc.rust-lang.org

Next steps

Assuming that there aren't semantics involved between these two words in English, I'd like to know what's your opinion on the next steps to take (so we can avoid the inconsistency and possible confusion).

What about replacing 'adapters' to 'adaptors' everywhere in the book?
@dcarral dcarral changed the title Inconsistency between iterator adapters vs iterator adaptors [Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors' Oct 15, 2015
dcarral added a commit to dcarral/rust that referenced this issue Oct 15, 2015
@dcarral
Replace 'adapters' to 'adaptors' in TRPL book
6bff154 
Regarding rust-lang#29063: Replace 'iterator adapters' appearances to
'iterator adaptors', thus embracing the terminology used along the
API docs and achieving consistency between both sources.
@dcarral dcarral mentioned this issue Oct 15, 2015
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Oct 15, 2015
@steveklabnik
Rollup merge of rust-lang#29066 - dcarral:fix_issue_29063, r=stevekla…
46d8a76 
…bnik

Regarding [rust-lang#29063 _[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors'_](rust-lang#29063) :

This PR replaces 'iterator adapters' appearances (in TRPL book) to 'iterator adaptors', thus embracing the terminology used along the API docs and achieving consistency between both sources.
Manishearth added a commit to Manishearth/rust that referenced this issue Oct 15, 2015
@Manishearth
Rollup merge of rust-lang#29066 - dcarral:fix_issue_29063, r=stevekla…
7be7ec3 
…bnik

Regarding [rust-lang#29063 _[Docs] Terminology inconsistency between 'iterator adapters' and 'iterator adaptors'_](rust-lang#29063) :

This PR replaces 'iterator adapters' appearances (in TRPL book) to 'iterator adaptors', thus embracing the terminology used along the API docs and achieving consistency between both sources.
@apasel422
Copy link
Contributor

I assume this was fixed by #29066?

@dcarral
Copy link
Contributor Author

dcarral commented Oct 16, 2015

Yes, this issue can be safely closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @dcarral @apasel422