Skip to content

Revisit type link coloring for rustdoc #29421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdinger opened this issue Oct 28, 2015 · 1 comment
Closed

Revisit type link coloring for rustdoc #29421

mdinger opened this issue Oct 28, 2015 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Oct 28, 2015

Rustdoc link coloring was updated in #29264 and there was some discussion about whether links should be underlined on hover and whether all types should be colored the same. See #29240 for the discussion. Extra colors were added to some of the links and merged (being merged presently) to get further experience in practice for the time being.

The link coloring and underlining should be revisited in the future to ascertain if any further change is necessary. Maybe this should be a part of #29329
@huonw huonw added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 28, 2015
@steveklabnik
Copy link
Member

It's been over a year, and these colors didn't cause an outrage, and were changed more times. Gonna consider this one done. Thanks @mdinger !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @huonw @mdinger