Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mir: Trans of fn calls unimplemented #29575

Closed
nikomatsakis opened this issue Nov 4, 2015 · 1 comment
Closed

Mir: Trans of fn calls unimplemented #29575

nikomatsakis opened this issue Nov 4, 2015 · 1 comment
Assignees
@nikomatsakis
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

This is a big one! We need to support function calls in MIR trans.
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html labels Nov 4, 2015
@nikomatsakis nikomatsakis self-assigned this Nov 4, 2015
@nikomatsakis
Copy link
Contributor Author

triage: P-medium

@rust-highfive rust-highfive added the P-medium Medium priority label Nov 4, 2015
@nikomatsakis nikomatsakis mentioned this issue Nov 4, 2015
Closed
16 tasks
@luqmana luqmana mentioned this issue Dec 13, 2015
Merged
@nagisa nagisa mentioned this issue Dec 19, 2015
Merged
bors added a commit that referenced this issue Jan 6, 2016
@bors
Auto merge of #30481 - nagisa:mir-calls-2, r=nikomatsakis
d5ac1a1 
r? @nikomatsakis

This is a pretty big PR conflating changes to a few different block terminators (Call, DivergingCall, Panic, Resume, Diverge), because they are somewhat closely related.

Each commit has a pretty good description on what is being changed in each commit. The end result is greatly simplified CFG and translation for calls (no success branch if the function is diverging, no cleanup branch if there’s nothing to cleanup etc).

Fixes #30480
Fixes #29767
Partialy solves #29575
Fixes #29573
@nagisa nagisa mentioned this issue Jan 12, 2016
Merged
bors added a commit that referenced this issue Jan 14, 2016
@bors
Auto merge of #30845 - nagisa:mir-extern-calls, r=<try>
29d24a3 
Supersedes #30517
Fixes #29575

cc @luqmana
r? @nikomatsakis
bors added a commit that referenced this issue Jan 19, 2016
@bors
Auto merge of #30845 - nagisa:mir-extern-calls, r=dotdash
41b74b1 
Supersedes #30517
Fixes #29575

cc @luqmana
r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikomatsakis @rust-highfive