Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vec::u3::is_ascii in auto-gen'd v0.3 docs, not in language #2959

Closed
Havvy opened this issue Jul 19, 2012 · 6 comments
Closed

vec::u3::is_ascii in auto-gen'd v0.3 docs, not in language #2959

Havvy opened this issue Jul 19, 2012 · 6 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Havvy
Copy link
Contributor

Havvy commented Jul 19, 2012

http://dl.rust-lang.org/doc/0.3/core/vec_u8.html#function-is_ascii

There's a function here, seemingly malformed (takes a T, but is not a generic function), but more importantly, is not a part of Rust 0.3.
@catamorphism
Copy link
Contributor

You're right, is_ascii was removed from vec well before the 0.3 release. I'm not sure why the library docs on the web site for 0.3 are so out of date. @graydon ?

@graydon
Copy link
Contributor

graydon commented Jul 19, 2012

it was never in core::vec::u8. This is a rustdoc bug, I think; the giveaway is that the code uses the module-local type parameter T, which is from the uint-templatized code over in core::u8. Where it still exists.

@pnkfelix
Copy link
Member

I infer from the comments that the 0.3 docs are periodically re-generated via a current rustdoc, and thus this bug will go away when rustdoc is fixed.

@pnkfelix
Copy link
Member

Not critical for 0.6; de-milestoning

@emberian
Copy link
Member

No longer relevant, can be closed.

@pnkfelix
Copy link
Member

Indeed. I am no longer confident that my earlier assertion (from comment above) that the docs are re-generated is correct; but in any case, without a more concrete illustration of a direct bug in rust doc, it is hard to take action on this. Closing.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Jul 8, 2023
@bors
Auto merge of rust-lang#2959 - RalfJung:vectest, r=RalfJung
89c2596 
vec tets: ensure pointer is still writeable

Under Tree Borrows, a pointer can become read-only: still allowing reads but not permitting writes any more. So these tests that want to check that pointers remain valid need to do writes to ensure that pointers indeed remain fully valid.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @adpaco-aws
Migrate foreign function, compiler-interface and kani-middle modules …
ee0ff7e 
…to use StableMIR (rust-lang#2959)

We still need internal APIs to handle things like:

- **FnAbi:** Support is pending this PR to be merged:
rust-lang#119094
- **Filter non-function items:** Also pending a fix on the rust side:
rust-lang#119135
- **Checking for reachable functions:** This is not needed in theory,
but std lib build fails since it unncovers an existing issue in Kani
with a function that was not previously included. I'll create an issue
for that. It's unrelated to this change though.
- **Function attribute handling**
- **Span error**

Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@graydon @pnkfelix @catamorphism @emberian @Havvy