Skip to content

Outstanding-loan error message does not follow style guide #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jruderman opened this issue Jul 20, 2012 · 2 comments
Closed

Outstanding-loan error message does not follow style guide #2972

jruderman opened this issue Jul 20, 2012 · 2 comments
Labels
A-lifetimes Area: Lifetimes / regions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
old 1.0 milestone

Comments

@jruderman
Copy link
Contributor

"assigning to mutable vec content prohibited due to outstanding loan"

"Prohibited" should be "disallowed" according to https://github.com/mozilla/rust/wiki/Note-style-guide. (Or "not allowed", but "X not allowed due to Y" is easy to misread.)
@lkuper
Copy link
Contributor

lkuper commented Jul 31, 2012

I was the one who added that point in the style guide (because both "not allowed" and "not permitted" were in use and I wanted to pick one, and "not allowed" seemed more popular in the unscientific poll I took). But I hadn't thought about "prohibited" -- that's a third possibility. I'm not sure we can in good faith tell people to stop using "prohibited" and instead use "disallowed"/"not allowed". Maybe none of this matters?

@lkuper
Copy link
Contributor

lkuper commented Aug 14, 2012

Yeah, I now think that that was a silly thing for me to have put in the style guide. I removed it and am closing this.

@lkuper lkuper closed this as completed Aug 14, 2012
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
@bors
Auto merge of rust-lang#9295 - Guilherme-Vasconcelos:manual-empty-str…
868dba9 
…ing-creation, r=dswij

Add `manual_empty_string_creations` lint

Closes rust-lang#2972

- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`

changelog: [`manual_empty_string_creations`]: Add lint for empty String not being created with `String::new()`
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 17, 2023
@bors
Auto merge of rust-lang#2972 - RalfJung:c-mem-functions, r=RalfJung
5b9168a 
C `mem` function shims: consistently treat "invalid" pointers as UB

Depends on rust-lang#113435.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lifetimes Area: Lifetimes / regions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@lkuper @jruderman