-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OOM building Servo after Rustup - deep recursion in mir #29740
Labels
A-MIR
Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
P-high
High priority
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
nrc
added
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
I-nominated
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-MIR
Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
labels
Nov 10, 2015
1 task
This is probably a dup of #29227. I'd be curious to know if it still occurs, as a partial fix has recently landed. I'm working on a more thorough fix now. |
I'll check it out in tomorrow's nightly. |
Minimized test case: https://gist.github.com/nikomatsakis/4cde4e099a20484efd15 |
triage: P-high (servo blocker) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Nov 12, 2015
In previous PRs, I changed the match desugaring to generate more efficient code for ints/chars and the like. But this doesn't help when you're matching strings, ranges, or other crazy complex things (leading to rust-lang#29740). This commit restructures match desugaring *yet again* to handle that case better -- basically we now degenerate to an if-else-if chain in such cases. ~~Note that this builds on rust-lang#29763 which will hopefully land soon. So ignore the first few commits.~~ landed now r? @Aatch since he's been reviewing the other commits in this series
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 12, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 12, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 12, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 13, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 16, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 25, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 25, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) DO NOT r+ or try+ this It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 25, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 25, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 26, 2015
Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Nov 27, 2015
…Manishearth Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8446) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this issue
Jun 12, 2017
…015-11-08) (from servo:rustup_20151110); r=SimonSapin+Ms2ger+jdm+Manishearth <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> Source-Repo: https://github.com/servo/servo Source-Revision: f13c72d68e1e7f49e241938bfd6e8a588c68e86b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…015-11-08) (from servo:rustup_20151110); r=SimonSapin+Ms2ger+jdm+Manishearth <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> Source-Repo: https://github.com/servo/servo Source-Revision: f13c72d68e1e7f49e241938bfd6e8a588c68e86b UltraBlame original commit: cfd63f6ba5819f3029d16d9681de754882ef67b4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…015-11-08) (from servo:rustup_20151110); r=SimonSapin+Ms2ger+jdm+Manishearth <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> Source-Repo: https://github.com/servo/servo Source-Revision: f13c72d68e1e7f49e241938bfd6e8a588c68e86b UltraBlame original commit: cfd63f6ba5819f3029d16d9681de754882ef67b4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…015-11-08) (from servo:rustup_20151110); r=SimonSapin+Ms2ger+jdm+Manishearth <s>DO NOT r+ or try+ this</s> <s>It causes an OOM (rust-lang/rust#29740) and can crash the OS. Probably will set our CI on fire. </s> Source-Repo: https://github.com/servo/servo Source-Revision: f13c72d68e1e7f49e241938bfd6e8a588c68e86b UltraBlame original commit: cfd63f6ba5819f3029d16d9681de754882ef67b4
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 24, 2024
…wjasper match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang#29740 because it's no longer relevant to how the code is structured today. r? `@matthewjasper`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 24, 2024
…wjasper match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang#29740 because it's no longer relevant to how the code is structured today. r? ``@matthewjasper``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Feb 25, 2024
Rollup merge of rust-lang#121374 - Nadrieril:factor-explain, r=matthewjasper match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang#29740 because it's no longer relevant to how the code is structured today. r? ``@matthewjasper``
bors
pushed a commit
to rust-lang/miri
that referenced
this issue
Feb 25, 2024
match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang/rust#29740 because it's no longer relevant to how the code is structured today. r? ``@matthewjasper``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-MIR
Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
P-high
High priority
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
The elided frames are all identical to the ones before and after.
Seems related, but different, to #29466
To repro, need to build Servo after a rustup, see this branch: servo/servo#8446. Occurs when building the script crate.
cc @nikomatsakis, @Manishearth
The text was updated successfully, but these errors were encountered: