Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIR] Add hair::Constant<'tcx> and change ExprKind::Repeat to use it #29789

Closed
nagisa opened this issue Nov 11, 2015 · 1 comment
Closed

[MIR] Add hair::Constant<'tcx> and change ExprKind::Repeat to use it #29789

nagisa opened this issue Nov 11, 2015 · 1 comment
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nagisa
Copy link
Member

nagisa commented Nov 11, 2015

See nagisa@234c5c3#commitcomment-14339085 and relevant FIXME in src/librustc_mir/hair/mod.rs
@nikomatsakis nikomatsakis added A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2015
@nikomatsakis nikomatsakis mentioned this issue Nov 11, 2015
Closed
16 tasks
@nikomatsakis
Copy link
Contributor

As a side-note, http://smallcultfollowing.com/babysteps/blog/2015/08/20/virtual-structs-part-3-bringing-enums-and-structs-together/ would solve this problem quite neatly, if we were to adopt and implement it. :)

fhahn added a commit to fhahn/rust that referenced this issue Jan 15, 2016
@fhahn
[MIR] use mir::repr::Constant in ExprKind::Repeat, close rust-lang#29789
9725fa6
@fhahn fhahn mentioned this issue Jan 15, 2016
Merged
bors added a commit that referenced this issue Jan 22, 2016
@bors
Auto merge of #30944 - fhahn:issue-29789-use-constant2, r=nagisa
18b851b 
This PR for  #29789 uses `rustc::repr::mir::Constant` in `ExprKind::Repeat`, which seems to fit quite nicely. Is there a reason for not re-using that type?
@bors bors closed this as completed in c786091 Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikomatsakis @nagisa