Tracking issue for getting pthread_t from JoinHandle #29791

alexcrichton · 2015-11-12T01:20:01Z

This is a tracking issue for the thread_extensions feature in the standard library which allows acquiring a pthread_t from a JoinHandle on Unix. Some questions on this are:

Should this trait also be implemented for Thread? (e.g. should we store the id there)
Does it deserve its own trait or is a one-off JoinHandleExt ok?
If you can get a pthread_t from a Thread can you also get a HANDLE from one on Windows?

The text was updated successfully, but these errors were encountered:

nagisa · 2015-11-12T11:45:45Z

See #29461.

alexcrichton · 2015-12-02T22:43:14Z

This ended up not landing just yet, so closing for now, can reopen if it's resubmitted though.

alexcrichton · 2015-12-04T00:07:59Z

Gonna reopen with #30177 in the queue

markuskobler · 2016-02-25T18:02:41Z

Looks like JoinHandleExt exposes as_pthread_t or handle now but is there a reason for not implementing something similar on Thread itself?

retep998 · 2016-02-25T18:36:32Z

The documentation for Thread says "A handle to a thread." however this is a complete lie. A Thread is nothing more than the name of the thread and a condition variable + mutex so it can unpark the thread. Since it doesn't actually have a handle to the thread it doesn't make any sense to implement those traits on Thread. That said as far as I can tell there isn't anything stopping Thread from having a handle to the thread.

markuskobler · 2016-02-25T19:03:04Z

Am I missing something obious. Is it not a case of exposing the following inner type with a ThreadExt?
https://github.com/rust-lang/rust/blob/master/src/libstd/sys/unix/thread.rs#L155
or
https://github.com/rust-lang/rust/blob/master/src/libstd/sys/windows/thread.rs#L81

markuskobler · 2016-02-25T19:37:49Z

Ignore me I understand the issue now. The use case I was after was something I thought would be as simple as thread::current().as_pthread_t() but I get the need for Thread using Arc now.

nagisa · 2016-02-25T19:51:43Z

@retep998 what our (representation of a) handle to a thread is, is up to us, not the operating system. As long as we’re capable of communicating to the OS’s threads, that is.

retep998 · 2016-02-25T20:49:03Z

@nagisa The point was simply that std::thread::Thread currently does not store a handle to the OS thread , so it didn't make sense to implement those traits for std::thread::Thread as the current implementation doesn't have a OS thread handle to provide.

@markuskobler To get the current OS thread handle you can just use pthread_self or GetCurrentThread depending upon the platform.

alexcrichton · 2016-03-11T18:04:09Z

🔔 This issue is now entering its cycle-long final comment period for tentative stabilization in 1.9 🔔

Some questions to consider as part of FCP:

Can we may these lowerings available through std::thread::Thread?
Can we somehow provide the ability to get the "current thread's OS handle"?

retep998 · 2016-03-11T18:15:47Z

Providing this sort of API through Thread would be convenient. As far as I can tell the only two ways to get a Thread are via JoinHandle or thread::current, the former of which has a handle which can be duplicated, and the later can be retrieved with the functions mentioned earlier. Note that for GetCurrentThread the handle obtained from that would have to be duplicated in order to be stored in Thread as the returned value is merely a magic value that always refers to the current thread and is never closed.

alexcrichton · 2016-04-07T17:21:11Z

The libs team discussed this during triage yesterday and the decision was to stabilize what we have as-is. We are likely to add these methods in any scenario and we can always add the methods to Thread at a later date.

This commit applies all stabilizations, renamings, and deprecations that the library team has decided on for the upcoming 1.9 release. All tracking issues have gone through a cycle-long "final comment period" and the specific APIs stabilized/deprecated are: Stable * `std::panic` * `std::panic::catch_unwind` (renamed from `recover`) * `std::panic::resume_unwind` (renamed from `propagate`) * `std::panic::AssertUnwindSafe` (renamed from `AssertRecoverSafe`) * `std::panic::UnwindSafe` (renamed from `RecoverSafe`) * `str::is_char_boundary` * `<*const T>::as_ref` * `<*mut T>::as_ref` * `<*mut T>::as_mut` * `AsciiExt::make_ascii_uppercase` * `AsciiExt::make_ascii_lowercase` * `char::decode_utf16` * `char::DecodeUtf16` * `char::DecodeUtf16Error` * `char::DecodeUtf16Error::unpaired_surrogate` * `BTreeSet::take` * `BTreeSet::replace` * `BTreeSet::get` * `HashSet::take` * `HashSet::replace` * `HashSet::get` * `OsString::with_capacity` * `OsString::clear` * `OsString::capacity` * `OsString::reserve` * `OsString::reserve_exact` * `OsStr::is_empty` * `OsStr::len` * `std::os::unix::thread` * `RawPthread` * `JoinHandleExt` * `JoinHandleExt::as_pthread_t` * `JoinHandleExt::into_pthread_t` * `HashSet::hasher` * `HashMap::hasher` * `CommandExt::exec` * `File::try_clone` * `SocketAddr::set_ip` * `SocketAddr::set_port` * `SocketAddrV4::set_ip` * `SocketAddrV4::set_port` * `SocketAddrV6::set_ip` * `SocketAddrV6::set_port` * `SocketAddrV6::set_flowinfo` * `SocketAddrV6::set_scope_id` * `<[T]>::copy_from_slice` * `ptr::read_volatile` * `ptr::write_volatile` * The `#[deprecated]` attribute * `OpenOptions::create_new` Deprecated * `std::raw::Slice` - use raw parts of `slice` module instead * `std::raw::Repr` - use raw parts of `slice` module instead * `str::char_range_at` - use slicing plus `chars()` plus `len_utf8` * `str::char_range_at_reverse` - use slicing plus `chars().rev()` plus `len_utf8` * `str::char_at` - use slicing plus `chars()` * `str::char_at_reverse` - use slicing plus `chars().rev()` * `str::slice_shift_char` - use `chars()` plus `Chars::as_str` * `CommandExt::session_leader` - use `before_exec` instead. Closes rust-lang#27719 cc rust-lang#27751 (deprecating the `Slice` bits) Closes rust-lang#27754 Closes rust-lang#27780 Closes rust-lang#27809 Closes rust-lang#27811 Closes rust-lang#27830 Closes rust-lang#28050 Closes rust-lang#29453 Closes rust-lang#29791 Closes rust-lang#29935 Closes rust-lang#30014 Closes rust-lang#30752 Closes rust-lang#31262 cc rust-lang#31398 (still need to deal with `before_exec`) Closes rust-lang#31405 Closes rust-lang#31572 Closes rust-lang#31755 Closes rust-lang#31756

std: Stabilize APIs for the 1.9 release This commit applies all stabilizations, renamings, and deprecations that the library team has decided on for the upcoming 1.9 release. All tracking issues have gone through a cycle-long "final comment period" and the specific APIs stabilized/deprecated are: Stable * `std::panic` * `std::panic::catch_unwind` (renamed from `recover`) * `std::panic::resume_unwind` (renamed from `propagate`) * `std::panic::AssertUnwindSafe` (renamed from `AssertRecoverSafe`) * `std::panic::UnwindSafe` (renamed from `RecoverSafe`) * `str::is_char_boundary` * `<*const T>::as_ref` * `<*mut T>::as_ref` * `<*mut T>::as_mut` * `AsciiExt::make_ascii_uppercase` * `AsciiExt::make_ascii_lowercase` * `char::decode_utf16` * `char::DecodeUtf16` * `char::DecodeUtf16Error` * `char::DecodeUtf16Error::unpaired_surrogate` * `BTreeSet::take` * `BTreeSet::replace` * `BTreeSet::get` * `HashSet::take` * `HashSet::replace` * `HashSet::get` * `OsString::with_capacity` * `OsString::clear` * `OsString::capacity` * `OsString::reserve` * `OsString::reserve_exact` * `OsStr::is_empty` * `OsStr::len` * `std::os::unix::thread` * `RawPthread` * `JoinHandleExt` * `JoinHandleExt::as_pthread_t` * `JoinHandleExt::into_pthread_t` * `HashSet::hasher` * `HashMap::hasher` * `CommandExt::exec` * `File::try_clone` * `SocketAddr::set_ip` * `SocketAddr::set_port` * `SocketAddrV4::set_ip` * `SocketAddrV4::set_port` * `SocketAddrV6::set_ip` * `SocketAddrV6::set_port` * `SocketAddrV6::set_flowinfo` * `SocketAddrV6::set_scope_id` * `<[T]>::copy_from_slice` * `ptr::read_volatile` * `ptr::write_volatile` * The `#[deprecated]` attribute * `OpenOptions::create_new` Deprecated * `std::raw::Slice` - use raw parts of `slice` module instead * `std::raw::Repr` - use raw parts of `slice` module instead * `str::char_range_at` - use slicing plus `chars()` plus `len_utf8` * `str::char_range_at_reverse` - use slicing plus `chars().rev()` plus `len_utf8` * `str::char_at` - use slicing plus `chars()` * `str::char_at_reverse` - use slicing plus `chars().rev()` * `str::slice_shift_char` - use `chars()` plus `Chars::as_str` * `CommandExt::session_leader` - use `before_exec` instead. Closes #27719 cc #27751 (deprecating the `Slice` bits) Closes #27754 Closes #27780 Closes #27809 Closes #27811 Closes #27830 Closes #28050 Closes #29453 Closes #29791 Closes #29935 Closes #30014 Closes #30752 Closes #31262 cc #31398 (still need to deal with `before_exec`) Closes #31405 Closes #31572 Closes #31755 Closes #31756

This commit applies all stabilizations, renamings, and deprecations that the library team has decided on for the upcoming 1.9 release. All tracking issues have gone through a cycle-long "final comment period" and the specific APIs stabilized/deprecated are: Stable * `std::panic` * `std::panic::catch_unwind` (renamed from `recover`) * `std::panic::resume_unwind` (renamed from `propagate`) * `std::panic::AssertUnwindSafe` (renamed from `AssertRecoverSafe`) * `std::panic::UnwindSafe` (renamed from `RecoverSafe`) * `str::is_char_boundary` * `<*const T>::as_ref` * `<*mut T>::as_ref` * `<*mut T>::as_mut` * `AsciiExt::make_ascii_uppercase` * `AsciiExt::make_ascii_lowercase` * `char::decode_utf16` * `char::DecodeUtf16` * `char::DecodeUtf16Error` * `char::DecodeUtf16Error::unpaired_surrogate` * `BTreeSet::take` * `BTreeSet::replace` * `BTreeSet::get` * `HashSet::take` * `HashSet::replace` * `HashSet::get` * `OsString::with_capacity` * `OsString::clear` * `OsString::capacity` * `OsString::reserve` * `OsString::reserve_exact` * `OsStr::is_empty` * `OsStr::len` * `std::os::unix::thread` * `RawPthread` * `JoinHandleExt` * `JoinHandleExt::as_pthread_t` * `JoinHandleExt::into_pthread_t` * `HashSet::hasher` * `HashMap::hasher` * `CommandExt::exec` * `File::try_clone` * `SocketAddr::set_ip` * `SocketAddr::set_port` * `SocketAddrV4::set_ip` * `SocketAddrV4::set_port` * `SocketAddrV6::set_ip` * `SocketAddrV6::set_port` * `SocketAddrV6::set_flowinfo` * `SocketAddrV6::set_scope_id` * `<[T]>::copy_from_slice` * `ptr::read_volatile` * `ptr::write_volatile` * The `#[deprecated]` attribute * `OpenOptions::create_new` Deprecated * `std::raw::Slice` - use raw parts of `slice` module instead * `std::raw::Repr` - use raw parts of `slice` module instead * `str::char_range_at` - use slicing plus `chars()` plus `len_utf8` * `str::char_range_at_reverse` - use slicing plus `chars().rev()` plus `len_utf8` * `str::char_at` - use slicing plus `chars()` * `str::char_at_reverse` - use slicing plus `chars().rev()` * `str::slice_shift_char` - use `chars()` plus `Chars::as_str` * `CommandExt::session_leader` - use `before_exec` instead. Closes rust-lang#27719 cc rust-lang#27751 (deprecating the `Slice` bits) Closes rust-lang#27754 Closes rust-lang#27780 Closes rust-lang#27809 Closes rust-lang#27811 Closes rust-lang#27830 Closes rust-lang#28050 Closes rust-lang#29453 Closes rust-lang#29791 Closes rust-lang#29935 Closes rust-lang#30014 Closes rust-lang#30752 Closes rust-lang#31262 cc rust-lang#31398 (still need to deal with `before_exec`) Closes rust-lang#31405 Closes rust-lang#31572 Closes rust-lang#31755 Closes rust-lang#31756

alexcrichton added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Nov 12, 2015

alexcrichton mentioned this issue Nov 12, 2015

AsRawHandle and IntoRawHandle for JoinHandle #29461

Closed

alexcrichton closed this as completed Dec 2, 2015

alexcrichton mentioned this issue Dec 4, 2015

AsRawHandle IntoRawHandle and JoinHandleExt for JoinHandle #30177

Merged

alexcrichton reopened this Dec 4, 2015

alexcrichton added the I-nominated label Mar 9, 2016

alexcrichton added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed I-nominated labels Mar 11, 2016

alexcrichton mentioned this issue Apr 7, 2016

std: Stabilize APIs for the 1.9 release #32804

Merged

bors closed this as completed in #32804 Apr 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for getting pthread_t from JoinHandle #29791

Tracking issue for getting pthread_t from JoinHandle #29791

alexcrichton commented Nov 12, 2015

nagisa commented Nov 12, 2015

alexcrichton commented Dec 2, 2015

alexcrichton commented Dec 4, 2015

markuskobler commented Feb 25, 2016

retep998 commented Feb 25, 2016

markuskobler commented Feb 25, 2016

markuskobler commented Feb 25, 2016

nagisa commented Feb 25, 2016

retep998 commented Feb 25, 2016

alexcrichton commented Mar 11, 2016

retep998 commented Mar 11, 2016

alexcrichton commented Apr 7, 2016

Tracking issue for getting pthread_t from JoinHandle #29791

Tracking issue for getting pthread_t from JoinHandle #29791

Comments

alexcrichton commented Nov 12, 2015

nagisa commented Nov 12, 2015

alexcrichton commented Dec 2, 2015

alexcrichton commented Dec 4, 2015

markuskobler commented Feb 25, 2016

retep998 commented Feb 25, 2016

markuskobler commented Feb 25, 2016

markuskobler commented Feb 25, 2016

nagisa commented Feb 25, 2016

retep998 commented Feb 25, 2016

alexcrichton commented Mar 11, 2016

retep998 commented Mar 11, 2016

alexcrichton commented Apr 7, 2016