Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::str::FromStr should mention it gets used in str::parse #29919

Closed
frewsxcv opened this issue Nov 18, 2015 · 3 comments
Closed

std::str::FromStr should mention it gets used in str::parse #29919

frewsxcv opened this issue Nov 18, 2015 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@frewsxcv
Copy link
Member

On the surface, the FromStr seems like a pretty pointless trait, but it should maybe mention it gets used in str::parse so it seems slightly less pointless

https://doc.rust-lang.org/nightly/std/str/trait.FromStr.html
@sfackler
Copy link
Member

👍

@steveklabnik steveklabnik added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Nov 19, 2015
@steveklabnik
Copy link
Member

part of #29375

@devonhollowood
Copy link
Contributor

I can do this.

@devonhollowood devonhollowood mentioned this issue Nov 20, 2015
Merged
bors added a commit that referenced this issue Nov 21, 2015
@bors
Auto merge of #29948 - devonhollowood:fromstr-parse, r=steveklabnik
ef5ee7d 
Implement #29919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @frewsxcv @sfackler @devonhollowood