Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[staged_api] #30008

Closed
brson opened this issue Nov 23, 2015 · 2 comments
Closed

Remove #[staged_api] #30008

brson opened this issue Nov 23, 2015 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Nov 23, 2015

The only purpose this serves is to make stability attributes modal, distinguishing between in-tree and out-of-tree use cases. #29952 though renamed #[deprecated] to #[rustc_deprecated], so afaik #[staged_api] does nothing useful.
@brson brson added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Nov 23, 2015
@brson
Copy link
Contributor Author

brson commented Nov 23, 2015

Fixing this should be a matter of removing the code that checks it in stability.rs, following the leads to other fallout in the compiler, removing the attribute from all the crates it's attached to.

@petrochenkov
Copy link
Contributor

Hm, what about #[stable] and #[unstable]? They are guarded by #[staged_api] as well.
But they can probably be guarded by #[feature(staged_api)] itself instead.

@petrochenkov petrochenkov mentioned this issue Nov 23, 2015
Merged
@Manishearth Manishearth added E-help-wanted Call for participation: Help is requested to fix this issue. and removed E-help-wanted Call for participation: Help is requested to fix this issue. labels Nov 24, 2015
bors added a commit that referenced this issue Nov 26, 2015
@bors
Auto merge of #30015 - petrochenkov:staged, r=brson
6d88afe 
Closes #30008

`#[stable]`, `#[unstable]` and `#[rustc_deprecated]` are now guarded by `#[feature(staged_api)]`

r? @brson
spikespaz pushed a commit to spikespaz/dotwalk-rs that referenced this issue Aug 29, 2024
@bors
Auto merge of #30015 - petrochenkov:staged, r=brson
909c980 
Closes rust-lang/rust#30008

`#[stable]`, `#[unstable]` and `#[rustc_deprecated]` are now guarded by `#[feature(staged_api)]`

r? @brson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @Manishearth @petrochenkov