Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

by-value methods show as inherited by Deref in Rustdoc #30607

Closed
elinorbgr opened this issue Dec 29, 2015 · 1 comment
Closed

by-value methods show as inherited by Deref in Rustdoc #30607

elinorbgr opened this issue Dec 29, 2015 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@elinorbgr
Copy link
Contributor

See for example: http://vberger.github.io/wayland-client-rs/wayland_client/cursor/struct.CursorImageBuffer.html

Unless the target type is Copy, it is not possible to call a method taking a self argument (it would result in a "cannot move out of borrowed content" error), so showing these methods as available in the docs is erroneous.
@bluss bluss added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 29, 2015
birkenfeld added a commit to birkenfeld/rust that referenced this issue May 4, 2016
@birkenfeld
rustdoc: do not show self-by-value methods from Deref target if not Copy
6434a28 
Fixes: rust-lang#30607
@birkenfeld birkenfeld mentioned this issue May 4, 2016
Closed
@alexcrichton
Copy link
Member

Discussion happened on #33396, but the conclusion was that we probably don't want to do this, so I'm going to close this.

@jrvidal jrvidal mentioned this issue Dec 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @elinorbgr @bluss