Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom target files don't support (pre|post)_link_objects_(dll|exe) #30868

Closed
carlpaten opened this issue Jan 13, 2016 · 2 comments · Fixed by #71769
Closed

Custom target files don't support (pre|post)_link_objects_(dll|exe) #30868

carlpaten opened this issue Jan 13, 2016 · 2 comments · Fixed by #71769
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@carlpaten
Copy link

I'm writing a target file for code that runs on the Xen hypervisor. In order to produce executable binaries, I need cargo to link with a bootloader object file. However, when producing static libraries etc., linking against this bootloader object is liable to cause all sorts of problems. I'd like to use the pre_link_objects_exe field of TargetOptions to link against the bootloader.

The fix seems like it would be simple: simply add a few key! calls in librustc_back/target/mod.rs.

I would really appreciate if this change was made, I could then publish a fully working Xen target :)

@steveklabnik steveklabnik added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed A-compiler labels Mar 24, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 24, 2017
@steveklabnik
Copy link
Member

Triage: not aware of any changes here

@petrochenkov
Copy link
Contributor

Fixed in #71769.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants