Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation about Child process detach #31289

Closed
LukasKalbertodt opened this issue Jan 29, 2016 · 3 comments
Closed

Documentation about Child process detach #31289

LukasKalbertodt opened this issue Jan 29, 2016 · 3 comments

Comments

@LukasKalbertodt
Copy link
Member

It would be nice, if the docs of process::Child would mention that the process is detached (and not joined) by default, when a Child object goes out of scope. Not having a Drop impl is too subtile IMO.
@steveklabnik
Copy link
Member

Part of #29370

@dirk
Copy link
Contributor

dirk commented Jan 30, 2016

@steveklabnik: I'd be happy to take this on. 😄

@steveklabnik
Copy link
Member

Please do! :)

On Jan 30, 2016, 11:59 -0500, Dirk Gadsdennotifications@github.com, wrote:

@steveklabnik(https://github.com/steveklabnik): I'd be happy to take this on.

—
Reply to this email directly orview it on GitHub(#31289 (comment)).

dirk added a commit to dirk/rust that referenced this issue Jan 31, 2016
@dirk
Safety docs about std::process::Child going out of scope
cee1695 
There is no `Drop` implemented for `Child`, so if it goes out
of scope in Rust-land and gets deallocated, the child process
will continue to exist and execute. If users want a guarantee
that the process has finished running and exited they must
manually use `kill`, `wait`, or `wait_with_output`.

Fixes rust-lang#31289.
@dirk dirk mentioned this issue Jan 31, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Feb 1, 2016
@steveklabnik
Rollup merge of rust-lang#31327 - dirk:dirk/process-child-safety-docs…
5ab00fd 
…, r=alexcrichton

`Drop` is not implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`.

Fixes rust-lang#31289.

r? @steveklabnik
steveklabnik added a commit to steveklabnik/rust that referenced this issue Feb 2, 2016
@steveklabnik
Rollup merge of rust-lang#31327 - dirk:dirk/process-child-safety-docs…
b2f3a51 
…, r=alexcrichton

`Drop` is not implemented for `Child`, so if it goes out of scope in Rust-land and gets deallocated the child process will continue to exist and execute. If users want a guarantee that the process has finished running and exited they must manually use `kill`, `wait`, or `wait_with_output`.

Fixes rust-lang#31289.

r? @steveklabnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dirk @steveklabnik @alexcrichton @LukasKalbertodt