Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make with SNAPSHOT_FILE should always use the new snapshot #3206

Closed
eholk opened this issue Aug 15, 2012 · 4 comments
Closed

make with SNAPSHOT_FILE should always use the new snapshot #3206

eholk opened this issue Aug 15, 2012 · 4 comments

Comments

@eholk
Copy link
Contributor

eholk commented Aug 15, 2012

Right now we have to do make clean first to pick up a custom snapshot. It'd be nice if make detected the SNAPSHOT_FILE variable and treated it the same as if snapshots.txt changed.
@jbclements
Copy link
Contributor

Ah, me. The first bug I've been assigned to look at. Is the current behavior really "wrong"?

@catamorphism
Copy link
Contributor

(bug triage) Still a bug as far as I know, but doesn't seem like a blocker.

@pnkfelix
Copy link
Member

part of #8058

@alexcrichton
Copy link
Member

Closing due to a lack of activity. I don't think that this is that much of an issue any more. It's pretty rare to run around with custom snapshots, and snapshots are easy enough to make these days that this probably just isn't worth it.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 5, 2023
@bors
Auto merge of rust-lang#3206 - RalfJung:simd-bitmask, r=RalfJung
487d999 
SIMD bitmasks: use 'round up to multiple of 8' rather than 'clamp to at least 8'

This should prepare us better for a future with non-power-of-2 vectors, if they ever happen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @eholk @pnkfelix @jbclements @catamorphism