Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate replacing little-lock exclusives with mutex_arc in taskgroup code. #3210

Closed
bblum opened this issue Aug 16, 2012 · 1 comment
Closed

Investigate replacing little-lock exclusives with mutex_arc in taskgroup code. #3210

bblum opened this issue Aug 16, 2012 · 1 comment

Comments

@bblum
Copy link
Contributor

bblum commented Aug 16, 2012

I don't at all expect this change to go through, and would be surprised if it were nearly as fast, and also it requires moving sync and arc to core... but I'd like to see the difference to get a grasp on how they perform.

For a rainy day.
@ghost ghost assigned bblum Aug 16, 2012
@bblum
Copy link
Contributor Author

bblum commented Aug 21, 2012

So investigated! Not only did it give a performance hit (like 10%, just by eyeballing the numbers, on task-perf-jargon-metal-smoke), as expected, it also had the interesting side effect that task-perf-linked-failure did not work properly because the mutex_arc supports killing tasks in the middle of it and poisoning the arc.

tl;dr: not just slow, also broken for an obtuse reason.

@bblum bblum closed this as completed Aug 21, 2012
@bblum bblum removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 5, 2023
@bors
Auto merge of rust-lang#3210 - rust-lang:rustup-2023-12-05, r=RalfJung
88d905c 
Automatic Rustup
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@karkhaz
Don't crash benchcomp when rounding non-numeric values (rust-lang#3211)
63dd504 
Previously, benchcomp would crash while rendering a scatterplot when
some results had non-numeric values, because those values were being
rounded using a function that doesn't handle non-numeric arguments.

This commit fixes rust-lang#3210.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bblum