Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc where clause is not reproducible #32555

Closed
sanxiyn opened this issue Mar 28, 2016 · 1 comment · Fixed by #33373
Closed

rustdoc where clause is not reproducible #32555

sanxiyn opened this issue Mar 28, 2016 · 1 comment · Fixed by #33373
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sanxiyn
Copy link
Member

sanxiyn commented Mar 28, 2016

For example, run make doc/alloc/index.html twice in a row and check doc/alloc/boxed/struct.Boxed.html. Where clause of flat_map can be either where U: IntoIterator, F: FnMut(Self::Item) -> U, or where F: FnMut(Self::Item) -> U, U: IntoIterator.

I think it is suspect that where_cluases function in src/librustdoc/clean/simplify.rs uses HashMap.
@sanxiyn sanxiyn added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 28, 2016
@mitaa
Copy link
Contributor

mitaa commented Mar 29, 2016

Related to #24473

birkenfeld added a commit to birkenfeld/rust that referenced this issue May 3, 2016
@birkenfeld
rustdoc: use btree map for where clauses
421e6fc 
to get more reproducible output.

Fixes: rust-lang#32555
@birkenfeld birkenfeld mentioned this issue May 3, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue May 8, 2016
@Manishearth
Rollup merge of rust-lang#33373 - birkenfeld:issue-32555, r=bluss
a5557c5 
rustdoc: use btree map for where clauses

to get more reproducible output.

Fixes: rust-lang#32555

I've looked at the other uses of HashMap in rustdoc, and they seem ok to (i.e. they use `iter()` and related only for constructing a new map, or when the output goes into independent files).

Not sure what the cause of rust-lang#24473 is, it shouldn't be where clauses, but maybe it was also fixed inbetween since May 2015.
Manishearth added a commit to Manishearth/rust that referenced this issue May 8, 2016
@Manishearth
Rollup merge of rust-lang#33373 - birkenfeld:issue-32555, r=bluss
c89d8c5 
rustdoc: use btree map for where clauses

to get more reproducible output.

Fixes: rust-lang#32555

I've looked at the other uses of HashMap in rustdoc, and they seem ok to (i.e. they use `iter()` and related only for constructing a new map, or when the output goes into independent files).

Not sure what the cause of rust-lang#24473 is, it shouldn't be where clauses, but maybe it was also fixed inbetween since May 2015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: use btree map for where clauses birkenfeld/rust
2 participants
@sanxiyn @mitaa