Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is unsafe code in resolve3! #3267

Closed
msullivan opened this issue Aug 24, 2012 · 1 comment
Closed

There is unsafe code in resolve3! #3267

msullivan opened this issue Aug 24, 2012 · 1 comment
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@msullivan
Copy link
Contributor

There is a bit of unsafe code in resolve3, where an unsafe pointer is taken to self and captured in closures.

This should be trivial to fix with explicit self types.
@ghost ghost assigned msullivan Aug 24, 2012
@msullivan
Copy link
Contributor Author

Initial attempts to fix it yielded segfaults. My initial code was bogus, it turns out, but it should have been rejected...

catamorphism pushed a commit to catamorphism/rust that referenced this issue Oct 8, 2012
@msullivan @catamorphism
Get rid of the unsafe hacks in resolve3. Closes rust-lang#3267.
e492fa5
@msullivan msullivan removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jan 22, 2024
@bors
Auto merge of rust-lang#3267 - rust-lang:rustup-2024-01-14, r=saethlin
2db3ed6 
Automatic Rustup
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jan 28, 2024
@bors
Auto merge of rust-lang#3267 - rust-lang:rustup-2024-01-14, r=saethlin
0c8e1e6 
Automatic Rustup
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@github-actions @tautschnig
Automatic cargo update to 2024-06-17 (rust-lang#3267)
8c7a25a 
Dependency upgrade resulting from `cargo update`.

Co-authored-by: tautschnig <1144736+tautschnig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msullivan