Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method matching against type parameters/boxed traits/classes is much less powerful than against impls #3274

Closed
msullivan opened this issue Aug 25, 2012 · 0 comments
Closed

Method matching against type parameters/boxed traits/classes is much less powerful than against impls #3274

msullivan opened this issue Aug 25, 2012 · 0 comments
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@msullivan
Copy link
Contributor

Once explicit self types work properly (see #3268), we want to be able to do all of the dirty tricks we do when matching against impls (matching by type assignability and autoref) when just resolving the method directly from the type. Right now, we only do these tricks when searching for a matching impl.
catamorphism pushed a commit to catamorphism/rust that referenced this issue Oct 8, 2012
@msullivan @catamorphism
Rework method lookup to properly handle self types for non impl match…
1f037b5 
…es. Closes rust-lang#3268. Closes rust-lang#3274.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@pi314mm
Function Contracts: remove instances of _renamed (rust-lang#3274)
1aee91f 
The current method for creating the modifies wrapper requires changing
the `ensures` clause to have `_renamed` variables which are unsafe
copies of the original function arguments. This causes issues with
regards to some possible tests as in rust-lang#3239.

This change removes the `_renamed` variables and instead simply changes
the modifies clauses within the replace to unsafely dereference the
pointer to modify the contents of it unsafely, condensing all instances
of unsafe Rust into a single location.

Resolves rust-lang#3239
Resolves rust-lang#3026
May affect rust-lang#3027. In my attempt to run this example with slight
modification to fit the current implementation, I got the error `CBMC
appears to have run out of memory. You may want to rerun your proof in
an environment with additional memory or use stubbing to reduce the size
of the code the verifier reasons about.` This suggests that the
compilation is working appropriately but the test case is just too large
for CBMC.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

Co-authored-by: Matias Scharager <mscharag@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msullivan