Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: allow using ninja to build LLVM #32809

Closed
nagisa opened this issue Apr 7, 2016 · 2 comments
Closed

rustbuild: allow using ninja to build LLVM #32809

nagisa opened this issue Apr 7, 2016 · 2 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nagisa
Copy link
Member

nagisa commented Apr 7, 2016

Ninja is much faster at building LLVM, especially when more cores get involved. We should either:

  1. Autodetect presence of ninja and use it automatically (with an option to force use of make); or
  2. Allow using ninja (via some option).
@nagisa nagisa added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 7, 2016
@alexcrichton
Copy link
Member

If anyone wants to dive into rustbuild, this should be a pretty easy bug to tackle! (in theory).

You'd probably want to start out by adding a check to sanity.rs to just see if ninja exists and then when we later build LLVM you should just be able to pass the argument to CMake!

We already just call cmake --build so I think that takes care of running ninja when it's configured, so we just need to tell CMake to use ninja.

@caipre
Copy link
Contributor

caipre commented Apr 8, 2016

I'll take this.

This was referenced Apr 9, 2016
Merged
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 14, 2016
@steveklabnik
Rollup merge of rust-lang#32865 - caipre:llvm-ninja, r=alexcrichton
d1f1f38 
Add rustbuild option to use Ninja for LLVM build

This change adds support for a `ninja` option in the `[llvm]` section of rustbuild's `config.toml`. When `true`, the option enables use of the Ninja build tool. Note that this change does not add support for Ninja to the old makefile based build system.

Closes rust-lang#32809

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @caipre @nagisa