-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: Add a tidy check to ensure Cargo.lock updates are checked in #32901
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
alexcrichton
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Apr 12, 2016
I would like to try and tackle this. Is this the home of the tidy checks? |
@gsquire Awesome! That is indeed where they all live |
Merged
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
May 8, 2016
Cargo lock tidy check A rebased PR for rust-lang#32901
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
May 8, 2016
Cargo lock tidy check A rebased PR for rust-lang#32901
Fixed in #33404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Right now we don't have the majority of devs using rustbuild, so it's easy to modify Cargo.toml but forget to generate a new lock file. This in turns leads to messy diffs after the change has landed because anyone working on rustbuild will start seeing that diff.
Let's get the bots to fail the build if Cargo.toml is updated and Cargo.lock does not reflect that change. Essentially, after building all Cargo.lock files should remain unchanged. I would propose doing this by tracking the git status of Cargo.lock via these steps:
git diff-index --quiet HEAD 'src/**/Cargo.lock'
The
make tidy
message should be a nice error message like:(or something like that)
This should be pretty easy to implement once #32590 lands (it'll just be adding a new check in our
tidy
tool). Another good way to jump into rustbuild if you're interested!The text was updated successfully, but these errors were encountered: