Lint pass to warn about integer suffixes

[catamorphism]

A lint pass to warn about 42u and such would be great, since the suffixes are no longer necessary.

[eholk]

The programmer may want a shorthand way to say "I really want this to be unsigned" though. I guess they could say let x : uint = 42, but I'd personally rather write let x = 42u.

[catamorphism]

That's why it'll just be a lint pass and not an error :-)

[eholk]

Okay, then I'd vote for off by default :)

[Aatch]

Nominating for production-ready.

[graydon]

Yeah, I don't know; this doesn't even really seem like a code smell to me, just a normal style choice, like variable naming or annotating-or-not each local variable type. They're totally necessary in some cases, and are shorter than type annotations.

Maybe it's just a question of the limit of what we consider "lint", but ISTM this path leads to a lint mode for every possible AST construct, and each lint pass does take a (small) amount of time to walk the AST of every function. They're not fused.

In any case, I don't feel this should block "production ready"

[bstrie]

This is also very easy to grep for, if necessary.

[graydon]

just a bug, removing milestone/nomination.

[bstrie]

Closing; this seems sufficiently innocuous that it doesn't really scream for a lint pass. Reopen if you feel otherwise.