Add support for new allocsize attribute in LLVM

[alexcrichton]

This is mostly a TODO issue for when we next upgrade LLVM. They have recently landed upstream support for a new attribute to tag functions with to indicate that they are an allocator.

This should hopefully obsolete our local patch and we should use these attributes instead.

[Mark-Simulacrum]

Did this happen? I'm not quite sure, but I feel like perhaps not. I think we do have a recent enough version of LLVM for this to be available....

[nagisa]

So, this allocsize attribute has this comment attached to it:

allocsize should not imply that a function is a traditional allocation function (e.g. that can be optimized out/...); it just tells us how many bytes exist at the pointer handed back by the function.

and it seems that the whole purpose if it revolves around removing stuff like bound checks. It might still be super worth it to attach these attributes, but they won’t help with optimising out the allocations.

[nagisa]

See also this

[alexcrichton]

It sounds like this isn't going to obsolete our local patch here, so closing.