Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing impls in std::str::Pattern docs #33113

Closed
durka opened this issue Apr 20, 2016 · 1 comment · Fixed by #33133
Closed

missing impls in std::str::Pattern docs #33113

durka opened this issue Apr 20, 2016 · 1 comment · Fixed by #33133

Comments

@durka
Copy link
Contributor

durka commented Apr 20, 2016

Some of the impls of Pattern disappeared from the std docs starting in beta. Compare:

They are also missing from the stable (and nightly) docs of core.
@bluss
Copy link
Member

bluss commented Apr 21, 2016

Related to #29503. I'm surprised, I would not call for CharEqPattern<C> where C: CharEq a blanket impl.

@mitaa mitaa mentioned this issue Apr 21, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 25, 2016
@Manishearth
Rollup merge of rust-lang#33133 - mitaa:rdoc-smth-smth-impl, r=alexcr…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5fba2bf 
…ichton

rustdoc: inline all the impls

This used to be done to avoid inlining impls referencing private items, but is now unnecessary since we actually check that impls do not reference non-doc-reachable items.

fixes rust-lang#32881
fixes rust-lang#33025
fixes rust-lang#33113

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: inline all the impls mitaa/rust
2 participants
@durka @bluss