Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document core::io #3317

Closed
brson opened this issue Aug 31, 2012 · 5 comments
Closed

Document core::io #3317

brson opened this issue Aug 31, 2012 · 5 comments

Comments

@brson
Copy link
Contributor

brson commented Aug 31, 2012

It's an important module, and it has no docs.
@catamorphism
Copy link
Contributor

It has some docs now, but it would be nice to document it better for 0.6

@brson
Copy link
Contributor Author

brson commented Mar 31, 2013

Doesn't look like this will happen

@brson brson mentioned this issue Mar 31, 2013
Closed
@steveklabnik steveklabnik mentioned this issue Apr 1, 2013
Closed
@bstrie
Copy link
Contributor

bstrie commented May 13, 2013

Nominating for Maturity 4.

@graydon
Copy link
Contributor

graydon commented Jun 20, 2013

accepted for production-ready milestone

@emberian
Copy link
Member

emberian commented Aug 5, 2013

As it is going away and str::rt::io is documented, closing.

@emberian emberian closed this as completed Aug 5, 2013
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@topecongiro
Merge pull request rust-lang#3317 from fyrchik/fix/edition
81067b1 
transition to Rust 2018
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
@bors
Auto merge of rust-lang#3330 - RossSmyth:win-fmt, r=RalfJung
f47732b 
Fix .\miri fmt on Windows

This allows .\miri fmt to work on Windows. Closes rust-lang#3317.

To reiterate, the problem with using `miri fmt` on Windows is that the CLI arguments to rustfmt are too long. Currently over 65,000 characters are used in the call to rustfmt, [which is incompatible with Windows](https://devblogs.microsoft.com/oldnewthing/20031210-00/?p=41553) as it is limited to (2^15 - 1) for all arguments plus all env vars.

Two things are done do get around this limit:

1. Call out to cargo-fmt for the crates that exist.
2. Batch rustfmt calls by length

Another alternative would be to just use rustfmt for everything and don't use cargo-fmt for the crates.

I don't know how much you guys may care about `miri fmt` time to run. I don't know the diff as it did not work before on my computer.

[I have another branch that solves this, but in a less permanent way](RossSmyth/miri/tree/windows-fmt). That was my initial attempt, and I learned that even with cargo-fmt and relative paths, the rustfmt call still has 27k characters. This is closer to the limit than I expected, so it would not be a permanent solution. So I went back to absolute paths & batching.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@adpaco-aws
Bump Kani version to 0.53.0 (rust-lang#3317)
fcc9d8b 
Bump Kani version to 0.53.0 and add notes for the upcoming release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@graydon @brson @catamorphism @emberian @bstrie