Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious failures related to dep_graph.rbml on the bots #33315

Closed
alexcrichton opened this issue May 1, 2016 · 1 comment
Closed

Spurious failures related to dep_graph.rbml on the bots #33315

alexcrichton opened this issue May 1, 2016 · 1 comment

Comments

@alexcrichton
Copy link
Member

Been seeing a bunch of these recently, gonna link up a few PRs to this to track them all here. @michaelwoerister here thought that this is due to the additions in #33171 which seems plausible to me as a bunch of compilations are now sharing the same incremental directory tmp.

cc @arielb1 (pinged on IRC about this)

bors added a commit that referenced this issue May 1, 2016
…r=alexcrichton

Fix a race condition caused by concurrently executed codegen unit tests.

This hopefully fixes issue #33315.

This short-term solution just makes sure that every test uses its own directory so they can't get into conflict with each other.

As a more long-term solution, I'd probably prefer to make the partitioning scheme specifiable via `-Ccodegen-units` (e.g. like `-Ccodegen-units=per-module`) so that we don't have to rely on `-Zincremental` in these test cases.

r? @alexcrichton
@alexcrichton
Copy link
Member Author

Believed to be fixed in #33317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant