-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious JSON parsing failure on bots #33390
Comments
@alexcrichton - do you have access the output it's failing to parse as json? |
I guess we could dump what we couldn't parse to stdout... |
Possibly #33313 ? |
We could certainly dump the full output, yeah. |
That'd probably do it, yeah. In general though it seems like the diagnostic of a failed test could be greatly improved to include things like the process exit code, process stdout/stderr, etc. @jonathandturner unfortunately there aren't these kind of logs for the tests :( |
Working on a quick fix to dump the failing input |
Another: #33376 (comment) (different test this time) |
Fix for old school error issues, improvements to new school This PR: * Fixes some old school error issues, specifically #33559, #33543, #33366 * Improves wording borrowck errors with match patterns * De-emphasize multi-line spans, so we don't color the single source character when we're trying to say "span starts here" * Rollup of #33392 (which should help fix #33390) r? @nikomatsakis
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/4079/steps/test/logs/stdio
https://gist.github.com/alexcrichton/997dd9cae99b934f945a01082d99313b
#33376 (comment)
I've seen this a few times at this point, not really sure what's going on.
cc @nikomatsakis, @jonathandturner -- the failure message here is unfortunately hiding lots of information like what happened to the underlying process, can we try and surface that?
The text was updated successfully, but these errors were encountered: