Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow an optional reason field to lint attributes #3358

Closed
brson opened this issue Sep 2, 2012 · 5 comments
Closed

Allow an optional reason field to lint attributes #3358

brson opened this issue Sep 2, 2012 · 5 comments
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Sep 2, 2012

Possibly like #[allow(types, reason = "whatever"). Then add another lint check that any allow attributes also have a reason.
@graydon
Copy link
Contributor

graydon commented Apr 25, 2013

+1 this should satisfy the most pedantic of pedants

@emberian
Copy link
Member

Nominating for production ready.

@pnkfelix
Copy link
Member

not accepted for milestone.

@emberian
Copy link
Member

Assigning to myself; will work on today.

@ghost ghost assigned emberian Aug 29, 2013
@catamorphism
Copy link
Contributor

Heh, didn't realize this existed. Since #9025 was closed, this should be closed too.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
@bors
Auto merge of rust-lang#3358 - RalfJung:zzz, r=RalfJung
65ec028 
give macOS even more time to sleep
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@qinheping
Upgrade toolchain to 2024-07-19 (rust-lang#3364)
9f230ba 
Resolves rust-lang#3358 

Related upstream commits: 
- rust-lang@21dc49c587 ptr::metadata:
avoid references to extern types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@graydon @brson @pnkfelix @catamorphism @emberian